Skip to content

Show personal Usage page #12771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2022
Merged

Show personal Usage page #12771

merged 3 commits into from
Sep 12, 2022

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented Sep 8, 2022 •
edited
Loading

Description

This PR reuses the existing Usage page to show personal usage.

Related Issue(s)

First part of #12686 (adding the Usage page "as is")

How to test

🤷🏻
No idea yet how to attribute personal account.

Release Notes

Show personal Usage page.

Documentation

Werft options:

  • /werft with-preview
  • /werft with-payment

@AlexTugarev
Copy link
Member Author

AlexTugarev commented Sep 8, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-at-usage-view.1
(with .werft/ from main)

@AlexTugarev AlexTugarev marked this pull request as ready for review September 9, 2022 07:28
@AlexTugarev AlexTugarev requested a review from a team September 9, 2022 07:28
@AlexTugarev AlexTugarev changed the title At/usage-view Show personal Usage page Sep 9, 2022
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 9, 2022
@AlexTugarev
Deactivate personal Usage page in the menu for now
aa894e4 
... it still remains navigatable.
@AlexTugarev
Copy link
Member Author

AlexTugarev commented Sep 9, 2022 •
edited
Loading

I pushed a second commit to disable the Usage entry in personal accounts menu. The page remains accessible via gitpod.io/usage URL. This is done, because ATM we've no means to attribute the usage to personal account, thus the page is expected to remain empty.

@andrew-farries andrew-farries self-assigned this Sep 12, 2022
andrew-farries
andrew-farries suggested changes Sep 12, 2022
View reviewed changes
components/dashboard/src/Usage.tsx
@@ -0,0 +1,47 @@
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is almost identical to src/teams/TeamUsage.tsx. Can we use one in both places?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-farries, I think there are two options, having the entry points separate (like now) and computing the props depending without consideration of location, or we merge, and need to sort out, what's meaningful inside of a single component depending on the location.
I'd prefer to go with the current state, just to avoid the complexity of properly creating the props for <UsageView />.

@roboquat roboquat merged commit 28c7e4f into main Sep 12, 2022
@roboquat roboquat deleted the at/usage-view branch September 12, 2022 07:37
@AlexTugarev AlexTugarev mentioned this pull request Sep 12, 2022
Closed
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-farries andrew-farries andrew-farries approved these changes

Assignees

@andrew-farries andrew-farries

Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XXL team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexTugarev @andrew-farries @roboquat